Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Only strip invariant.load from special pointers #57386

Merged
merged 3 commits into from
Feb 18, 2025

Conversation

vchuravy
Copy link
Member

Other backends (in this case NVPTX) require that invariant.load
metadata is maintained to generate non-coherent loads.

Currently, we unconditionally strip that metadata from all loads,
since our other uses of it may have become invalid.

x-ref: llvm/llvm-project#112834 JuliaGPU/CUDA.jl#2531

@vchuravy vchuravy force-pushed the vc/dont_strip_always_invariant_load branch from 8d29aa2 to 7b6646f Compare February 13, 2025 11:14
vchuravy and others added 3 commits February 17, 2025 11:34
Other backends (in this case NVPTX) require that `invariant.load`
metadata is maintained to generate non-coherent loads.

Currently, we unconditionally strip that metadata from all loads,
since our other uses of it may have become invalid.
@vchuravy vchuravy force-pushed the vc/dont_strip_always_invariant_load branch from 25aeb46 to cc34663 Compare February 17, 2025 10:34
@vchuravy
Copy link
Member Author

@nanosoldier runtests(ALL, vs = ":master", configuration = (buildflags=["LLVM_ASSERTIONS=1", "FORCE_ASSERTIONS=1"],), vs_configuration = (buildflags = ["LLVM_ASSERTIONS=1", "FORCE_ASSERTIONS=1"],))

@nanosoldier
Copy link
Collaborator

The package evaluation job you requested has completed - possible new issues were detected.
The full report is available.

Report summary

❗ Packages that crashed

2 packages crashed only on the current version.

  • An internal error was encountered: 1 packages
  • A segmentation fault happened: 1 packages

11 packages crashed on the previous version too.

✖ Packages that failed

36 packages failed only on the current version.

  • Package has test failures: 3 packages
  • Package tests unexpectedly errored: 2 packages
  • Tests became inactive: 1 packages
  • Test duration exceeded the time limit: 28 packages
  • Test log exceeded the size limit: 2 packages

1207 packages failed on the previous version too.

✔ Packages that passed tests

33 packages passed tests only on the current version.

  • Other: 33 packages

5154 packages passed tests on the previous version too.

~ Packages that at least loaded

10 packages successfully loaded only on the current version.

  • Other: 10 packages

2954 packages successfully loaded on the previous version too.

➖ Packages that were skipped altogether

1 packages were skipped only on the current version.

  • Package could not be installed: 1 packages

904 packages were skipped on the previous version too.

@vchuravy vchuravy merged commit 29da86b into master Feb 18, 2025
8 checks passed
@vchuravy vchuravy deleted the vc/dont_strip_always_invariant_load branch February 18, 2025 12:28
@vchuravy vchuravy added compiler:codegen Generation of LLVM IR and native code backport 1.10 Change should be backported to the 1.10 release backport 1.11 Change should be backported to release-1.11 backport 1.12 Change should be backported to release-1.12 labels Feb 18, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
backport 1.10 Change should be backported to the 1.10 release backport 1.11 Change should be backported to release-1.11 backport 1.12 Change should be backported to release-1.12 compiler:codegen Generation of LLVM IR and native code
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants