-
-
Notifications
You must be signed in to change notification settings - Fork 5.5k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Only strip invariant.load from special pointers #57386
Conversation
8d29aa2
to
7b6646f
Compare
Other backends (in this case NVPTX) require that `invariant.load` metadata is maintained to generate non-coherent loads. Currently, we unconditionally strip that metadata from all loads, since our other uses of it may have become invalid.
Co-authored-by: Gabriel Baraldi <[email protected]>
25aeb46
to
cc34663
Compare
@nanosoldier |
The package evaluation job you requested has completed - possible new issues were detected. Report summary❗ Packages that crashed2 packages crashed only on the current version.
11 packages crashed on the previous version too. ✖ Packages that failed36 packages failed only on the current version.
1207 packages failed on the previous version too. ✔ Packages that passed tests33 packages passed tests only on the current version.
5154 packages passed tests on the previous version too. ~ Packages that at least loaded10 packages successfully loaded only on the current version.
2954 packages successfully loaded on the previous version too. ➖ Packages that were skipped altogether1 packages were skipped only on the current version.
904 packages were skipped on the previous version too. |
Other backends (in this case NVPTX) require that
invariant.load
metadata is maintained to generate non-coherent loads.
Currently, we unconditionally strip that metadata from all loads,
since our other uses of it may have become invalid.
x-ref: llvm/llvm-project#112834 JuliaGPU/CUDA.jl#2531