Make remaining float intrinsics require float arguments #57398
+155
−82
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
xal-0
force-pushed
the
strict-float-intrinsics
branch
from
b2bfc59 to
4eb0368
Compare
oscardssmith
approved these changes
Feb 13, 2025
xal-0
force-pushed
the
strict-float-intrinsics
branch
from
0dce3a3 to
1bd20ce
Compare
vtjnash
reviewed
Feb 18, 2025
vtjnash
reviewed
Feb 18, 2025
| @@ -92,7 +94,7 @@ compiled_addi(x, y) = Core.Intrinsics.add_int(x, y) | |||
| @test compiled_addi(true, true) === false | |||
|
|
|||
| compiled_addf(x, y) = Core.Intrinsics.add_float(x, y) | |||
| @test compiled_addf(C_NULL, C_NULL) === C_NULL | |||
| @test_throws ErrorException compiled_addf(C_NULL, C_NULL) === C_NULL | |||
There was a problem hiding this comment.
Suggested change
| @test_throws ErrorException compiled_addf(C_NULL, C_NULL) === C_NULL | |
| @test_throws ErrorException compiled_addf(C_NULL, C_NULL) |
vtjnash
approved these changes
Feb 18, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The
fptrunc/fpextintrinsics were modified in #57160 to throw on non-float arguments.fptosi/fptouirequire their source to be a floatsitofp/uitofprequire their destination type to be a floatAlso fixes #57384.