Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Make false a strong zero against 1//0 #57409

Open
wants to merge 3 commits into
base: master
Choose a base branch
from
Open

Make false a strong zero against 1//0 #57409

wants to merge 3 commits into from

Conversation

LilithHafner
Copy link
Member

Make false a strong zero against rationals and add tests.

Also add tests for *(::Bool, ::Float64) because I didn't find tests for that anywhere.

Implements #57068

@LilithHafner LilithHafner added rationals The Rational type and values thereof maths Mathematical functions minor change Marginal behavior change acceptable for a minor release needs pkgeval Tests for all registered packages should be run with this change labels Feb 14, 2025
@LilithHafner LilithHafner linked an issue Feb 14, 2025 that may be closed by this pull request
Should false * 1//0 == 0//1? #57068
Open
@LilithHafner
Copy link
Member Author

An alternative approach would be to define false as a strong zero against Real or even Number but that would cause ambiguities with, among other things, *(::MyInteger, ::MyInteger) (where MyInteger is a subtype of Integer)

@LilithHafner
Copy link
Member Author

@nanosoldier runtests()

1 similar comment
@maleadt
Copy link
Member

maleadt commented Feb 17, 2025

@nanosoldier runtests()

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
maths Mathematical functions minor change Marginal behavior change acceptable for a minor release needs pkgeval Tests for all registered packages should be run with this change rationals The Rational type and values thereof
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Should false * 1//0 == 0//1?
2 participants
@LilithHafner @maleadt