Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

test: Compiler: relax flaky codegen test #57432

Open
wants to merge 5 commits into
base: master
Choose a base branch
from

Conversation

nsajko
Copy link
Contributor

@nsajko nsajko commented Feb 16, 2025

Relaxing it should help prevent spurious CI failures until someone does a proper fix.

Updates #56748

@nsajko nsajko added test This change adds or pertains to unit tests compiler:codegen Generation of LLVM IR and native code ci Continuous integration labels Feb 16, 2025
@adienes
Copy link
Contributor

adienes commented Feb 17, 2025

why not just @test_broken that seems harder to forget about (vs this approach seems easy to accidentally never re-tighten the bound)

@giordano
Copy link
Contributor

giordano commented Feb 17, 2025

Test broken shouldn't be used for tests which fail intermittently, you'd get test failures the tested condition is true. You can skip it, but marking as broken isn't correct.

@adienes
Copy link
Contributor

adienes commented Feb 17, 2025

agreed, @test_skip looks more appropriate than @test_broken

@Keno
Copy link
Member

Keno commented Feb 17, 2025

it would still be good to understand where this failure is coming from and if there is a sequence of tests that if run on the same processor deterministically causes this failure. Usually what I do is JULIA_CPU_THREADS=1 runtests.jl ... and then the list of all the tests that ran on the same worker on CI.

@nsajko nsajko force-pushed the test_compiler_codegen_ci branch from 97eb832 to 7976a89 Compare February 17, 2025 21:54
@oscardssmith
Copy link
Member

Is this unrelated to the fact that @allocated on nightly is broken?

@nsajko
Copy link
Contributor Author

nsajko commented Feb 17, 2025

Is this unrelated to the fact that @allocated on nightly is broken?

At least part of the issue here seems to be system-specific, so I guess it's a codegen issue 🤷

nsajko and others added 5 commits February 19, 2025 18:37
Relaxing it should help prevent spurious CI failures until someone does
a proper fix.

Updates JuliaLang#56748
Co-authored-by: Mosè Giordano <[email protected]>
@nsajko nsajko force-pushed the test_compiler_codegen_ci branch from ce81f20 to 81fe702 Compare February 19, 2025 17:38
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
ci Continuous integration compiler:codegen Generation of LLVM IR and native code test This change adds or pertains to unit tests
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants