-
-
Notifications
You must be signed in to change notification settings - Fork 5.5k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
test: Compiler: relax flaky codegen test #57432
base: master
Are you sure you want to change the base?
Conversation
why not just |
Test broken shouldn't be used for tests which fail intermittently, you'd get test failures the tested condition is true. You can skip it, but marking as broken isn't correct. |
agreed, |
it would still be good to understand where this failure is coming from and if there is a sequence of tests that if run on the same processor deterministically causes this failure. Usually what I do is |
97eb832
to
7976a89
Compare
Is this unrelated to the fact that |
At least part of the issue here seems to be system-specific, so I guess it's a codegen issue 🤷 |
Relaxing it should help prevent spurious CI failures until someone does a proper fix. Updates JuliaLang#56748
Co-authored-by: Mosè Giordano <[email protected]>
Co-authored-by: Jameson Nash <[email protected]>
Co-authored-by: Jameson Nash <[email protected]>
ce81f20
to
81fe702
Compare
Relaxing it should help prevent spurious CI failures until someone does a proper fix.
Updates #56748