Convert some julia-repl examples to doctests #57452
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
KristofferC
reviewed
Feb 18, 2025
lgoettgens
force-pushed
the
lg/jldoctest
branch
from
58f3899 to
82c24b3
Compare
|
The remaininng CI failures seem unrelated to my changes. Could someone please review this? Maybe @LilithHafner ? |
| @@ -102,7 +102,7 @@ g (generic function with 1 method) | |||
| julia> @code_typed f([1.0]) | |||
| CodeInfo( | |||
| 1 ─ %1 = invoke Main.g(_2::AbstractArray)::Float64 | |||
| 1 ─ %1 = invoke g(A::AbstractArray)::Float64 | |||
There was a problem hiding this comment.
This indentation is strange. I wonder if that change was intentional. Might be worh bisecting it.
|
That said, this PR LGTM. Thanks for the contribution! |
LilithHafner
added
docs
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Some progress towards #56921.