Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fixes for building on AArch64 with Clang #314

Merged
merged 3 commits into from
Jan 8, 2025
Merged

Conversation

ararslan
Copy link
Member

@ararslan ararslan commented Jan 7, 2025

See individual commit messages for descriptions and motivations of changes. We should tag a new patch version after this is merged.

Make.inc Outdated Show resolved Hide resolved
One change in PR 305 was not quite right: it changed a check for whether
`$(ARCH)` is `aarch64` to a check for whether it's `aarch64 riscv64`,
which can never be true. It was a non-functional change on RISC-V (since
it can't be true) but broke AArch64, at least for FreeBSD. Notably,
changing the check to what I assume was intended, i.e. `aarch64` or
`riscv64`, breaks RISC-V. So this commit instead reverts this one change
in 305.
Move the unconditional `?=` definitions below all conditional
definitions so that conditional `?=`s can take precedence. Also forcibly
set `USEGCC=0` when `USECLANG=1`, otherwise the things guarded behind
`USEGCC=1` will be visible. Without these changes, `gmake` on FreeBSD
AArch64 incorrectly uses gcc instead of clang.
@ararslan ararslan force-pushed the aa/clang-aarch64-fixes branch from 8f0fd2c to 4d2d83f Compare January 7, 2025 21:14
@ararslan ararslan requested a review from giordano January 7, 2025 21:25
Copy link
Member

@giordano giordano left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me as far as I can tell, the ifeq test was definitely wrong (it could never be true)

@ararslan ararslan merged commit db24332 into master Jan 8, 2025
16 checks passed
@ararslan ararslan deleted the aa/clang-aarch64-fixes branch January 8, 2025 00:08
ViralBShah pushed a commit to JuliaLang/julia that referenced this pull request Jan 8, 2025
This fixes building on FreeBSD AArch64, as there was a regression in
OpenLibm 0.8.4; see JuliaMath/openlibm#314.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants