Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Initialize all fenv_t with __fe_dfl_env #316

Closed
wants to merge 1 commit into from
Closed

Conversation

giordano
Copy link
Member

Opening as a draft, but the hope is to fix #278.

@giordano
Copy link
Member Author

At least CI here is happy, as much that means 🙂 Now I'm recompiling Julia on JuliaLang/julia@3c7bc45 with this change, to see if this is enough to fix compilation failure mentioned at #278 (comment).

@xctan
Copy link
Contributor

xctan commented Jan 10, 2025

It looks like feholdexcept() is also responsible for initializing fenv_t env, even if there are no actual hardware floating-point exception traps, just as on RISC-V. Instead of initializing env in the first place, can you try implementing fenv_t loading in feholdexcept(), which is a no-op on RISC-V?

@giordano
Copy link
Member Author

Unfortunately this PR doesn't solve the issue reported at #278 (comment) 😞

Instead of initializing env in the first place, can you try implementing fenv_t loading in feholdexcept(), which is a no-op on RISC-V?

I'm not quite sure what you mean (sorry, I'm not really familiar with openlibm nor riscv-v internals, I'm just trying to fix the issue I observed). Would you be able to open a PR? Or at least give me some more directions of what to do?

@giordano giordano closed this Jan 12, 2025
@giordano giordano deleted the mg/init-fenvt branch January 12, 2025 21:21
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

aarch64/fenv.c:41:23: error: invalid initializer
2 participants