Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Stats & More Polish on Metadata Matching #3538

Merged
merged 16 commits into from
Feb 9, 2025
Merged

Conversation

majora2007
Copy link
Member

@majora2007 majora2007 commented Feb 9, 2025

The feedback and ideas have been great these last few days with this feature. A lot of users brought up different needs that I would have never caught alone with the way my system is setup. With this PR, I feel that the feature is pretty solid at this point. I implemented as much feedback as I could and polished off a lot of the bugs.

I will be shifting over to finishing off the rest of the Overhaul work from this point on. Continue to bring up issues and enhancements as you see them. I look forward to launching this release for all users.

Added

  • Added: Added a new stat for if the server uses metadata matching

Changed

  • Changed: (Kavita+) Rearranged the ordering for Manage Metadata preference item (develop)
  • Changed: (Kavita+) Hide Valid until on Matched Metadata screen as it's not applicable for any filters (develop)
  • Changed: (Kavita+) Don't overwrite summary/release year/localized name when unlocked and no override
  • Changed: Reverted a change that made the read more (series detail summary) too short for me (develop)
  • Changed: (Kavita+) Don't write non-roman characters to localized name. Tweaked the logic to be much better at writing localized name. (develop)
  • Changed: (Kavita+) Preemptively remove a manually matched series once the modal closes on matched metadata. (develop)

Fixed

  • Fixed: (Kavita+) Fixed an issue where whitelist setting could be an empty string, thus breaking all tag processing (develop)
  • Fixed: Fixed sorting in a lot of tables throughout the app (develop)
  • Fixed: (Kavita+) Fixed a long standing bug where background series processing (fetching metadata for K+) wasn't pulling anything more than the first 25 series over and over.
  • Fixed: (Kavita+) Fixed inability to turn off Do not match on a series (develop)
  • Fixed: (Kavita+) Fixed allow metadata matching library setting not showing disabled and off. (develop)
  • Fixed: (Kavita+) Fixed a bug where Needs Manual Match was showing stuff in Don't match. (develop)
  • Fixed: Fixed add device button being broken (Fixes Add devices button is grayed out #3472 )
  • Fixed: Fixed a bug where an admin editing a user was unable to save the form without a valid email, even though non-valid emails are allowed. (Fixes Cannot Edit User without Valid (structured) Email Address Set #3478 )
  • Fixed: Fixed a bug where person links wouldn't be url encoded (Fixes Character name with a slash (/) does not encode in the URL as %2F #3499)
  • Fixed: Fixed a bug where characters weren't being saved on the backend (Fixes Characters not being added to series or volumes when saving #3520)

Part of #2979

…al stats server automatically, like Kavita+ does.

Added a new stat for if using metadata downloading feature.
Fixed an issue where Whitelist setting could get set with an empty string, thus breaking tag processing.
…able for a filter that I'm not enabling atm.

Fixed sorting in some tables and added it matched metadata
…g metadata for K+) wasn't pulling anything more than the first 25 series over and over.
… without a valid email, even though non-valid emails are allowed.
@majora2007 majora2007 merged commit 5d6a5f0 into develop Feb 9, 2025
3 of 6 checks passed
@majora2007 majora2007 deleted the feature/stats-v3-extra branch February 9, 2025 20:39
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
1 participant