Minor refresh #46
Merged
Minor refresh #46
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Keats
requested changes
Jun 30, 2021
.github/workflows/quick-check.yml
Outdated
| - name: Cargo check | ||
| uses: actions-rs/cargo@v1 | ||
| with: | ||
| command: check |
There was a problem hiding this comment.
why add that compared to the current pipeline?
There was a problem hiding this comment.
I did not notice your pipeline at first :)
I also cannot run your pipeline in my fork (beside when opening a PR) so the github workflow makes it easier to check on my end.
I can remove it from the PR if you prefer.
There was a problem hiding this comment.
yes please, no need for 2 CI setup
Cargo.toml
Outdated
| authors = ["Vincent Prouillet <[email protected]>"] | ||
| license = "MIT" | ||
| description = "A simple way to get started with a project by scaffolding from a template powered by the tera engine" |
|
Any big features missing for your usage? |
Not at that point but I did not test extensively yet. I will happily report back or open a PR if so. Thanks for asking ! |
Since you asked :) #48 |
Keats
approved these changes
Jul 3, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR fixes a few linter grumbles and mainly adds keywords for a better discovery.
I wish I found this project/repo earlier :)