Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

impl AsRegex for LazyLock<Regex> #361

Merged
merged 2 commits into from
Dec 7, 2024
Merged

impl AsRegex for LazyLock<Regex> #361

merged 2 commits into from
Dec 7, 2024

Conversation

hdoordt
Copy link
Contributor

@hdoordt hdoordt commented Dec 2, 2024

Thanks for an amazing crate!

This PR does basically what it says in the title.

Keats
Keats requested changes Dec 3, 2024
View reviewed changes
Copy link
Owner

@Keats Keats left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can you add a test in validator_derive_tests please?

@hdoordt
Copy link
Contributor Author

hdoordt commented Dec 6, 2024

@Keats I removed the impl for LazyCell, as it didn't make much sense

@hdoordt hdoordt changed the title impl AsRegex for LazyCell<Regex> and LazyLock<Regex> impl AsRegex for LazyLock<Regex> Dec 6, 2024
@Keats Keats merged commit c38ae67 into Keats:master Dec 7, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Keats Keats Keats approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@hdoordt @Keats