Fix quickCheckAPI-A fail when MAX_TEXTURE_IMAGE_UNITS > 32.(KhronosGr… #3655
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…oup#3654) GL['TEXTURE'+i] will report not defined when MAX_TEXTURE_IMAGE_UNITS > 32. Add more TEXTURE_IMAGE_UNITS support for modern GPU that may support 64 or more. Fixes KhronosGroup#3654 . Signed-off-by: Wujian Sun <[email protected]>
|
|
|
Can anyone help review here? |
kenrussell
approved these changes
May 29, 2024
|
Hi @kenrussell , |
|
@WujianSun thanks for your patch. |
|
Hi @kenrussell , |
|
@WujianSun : yes, please put up a pull request modifying these two copies of that file: Thanks. |
WujianSun
deleted the
bugfix/fix-quickCheckAPI-A-fail-when-MAX_TEXTURE_IMAGE_UNITS-is-greater-than-32
branch
WujianSun
added a commit
to WujianSun/WebGL
that referenced
this pull request
May 31, 2024
Pick the fixs(KhronosGroup#3655) for 2.0.0 and 1.0.3. Fixes KhronosGroup#3654. Signed-off-by: Wujian Sun <[email protected]>
WujianSun
added a commit
to WujianSun/WebGL
that referenced
this pull request
May 31, 2024
Pick the fixs(KhronosGroup#3655) for 2.0.0 and 1.0.3. Fixes KhronosGroup#3654. Signed-off-by: Wujian Sun <[email protected]>
kenrussell
pushed a commit
that referenced
this pull request
May 31, 2024
Pick the fixs(#3655) for 2.0.0 and 1.0.3. Fixes #3654. Signed-off-by: Wujian Sun <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
…oup#3654)
GL['TEXTURE'+i] will report not defined when MAX_TEXTURE_IMAGE_UNITS > 32.
Add more TEXTURE_IMAGE_UNITS support for modern GPU that may support 64 or more.
Fixes #3654 .