Develop zk #59
Open
Develop zk #59
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
* remove_dynamic_fee -> Done * fix bugs and add deployment script * rename stuffs * remove unused var * move feeinPrecision to Factory and Rename DMM to KS * rename DMM to KS * remove dynamic fee, add fee options * fix deployment script * add modifier for checking fee setter * Add KSRouter, change feeOptions to public, remove getFinalFee * update hardhat config * fix hardhat config * add router test * rename dmmSwapCall to ksSwapCall, add ZapInV2 * fix test * rename deployKs to deployKyberSwap Co-authored-by: Jensen Tran <[email protected]>
* Mutiply the fee options by 10 times * Add tests for changing BPS and add a new feeOption * Add FEE_UNITS * Update _mintFee func
* Fix overflow mul div
* Update formula in _calculateSyncTotalSupply * Rename to KSZapIn * Pass factory address as a parameter * Add some test for KSZapIn * Fix KSZap: rename, add configMaster, add/remove factory from whitelist * add test for calculateZapOutAmount if tokenIn is token1 instead of token0 * fix test for zapOut tokenIn is token1 * fix factory whitelist check * fix quan's comment on configMasterUpdated event Co-authored-by: Tran Vu <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.