-
Notifications
You must be signed in to change notification settings - Fork 3
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fallback to remote data files while JSOC is unavailable #346
Conversation
381a6de
to
536ed51
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I've not left very many useful comments here, but my high-level suggestion would be to refactor this such that get_response_table
is unchanged and to instead just pass in the appropriate paths (using the appropriate version number) in the functions that call get_response_table
. The same goes for get_error_table
.
This is making me realize that all of the logic around how this information is pulled into the higher-level functions is overly complex which is largely my fault. However, this refactor should be independent of what is going on with the JSOC currently.
0cde18c
to
fafdbb8
Compare
1c30a44
to
1306992
Compare
602128b
to
d17c268
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I have reservations about this major of a breaking change, but I don't know of another way. My biggest issue at present is the API for getting different versions of the correction and error tables. I've added comments for a possible alternative.
f2ef171
to
b90144c
Compare
Co-authored-by: Will Barnes <[email protected]>
The goal here is to remove all of the parsing code and logic from the methods/functions that require a table either from the JSOC or offline files.
The angle here is to make the user pick the table and pass that as input as a new required input.
This avoids us having code for all the various inputs which are possible. Now the user will have to select the table they want via util functions.
TODO: