LibWeb: Move z-index to table wrapper box
#3595
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
When drawing a table, some of the CSS properties must be moved from the table grid box to an anonamyous table wrapper box. One of these properties is `position`. `z-index` however is not. This leads to the following behavior if a table has both `position` and `z-index`: * The wrapper box has the `position`, but a `z-index` of `auto`. * The grid box has the `z-index`, but `position: static`. This effectively means that the `z-index property is ignored since it has no effect on non-positioned elements. This behavior contradicts what other browsers do and causes layout issues on websites. To align Ladybird behavior with other browser this commit also moves the `z-index` property to the wrapper box.
kalenikaliaksandr
approved these changes
Feb 16, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When drawing a table, some of the CSS properties must be moved from the table grid box to an anonamyous table wrapper box. One of these properties is
position.z-indexhowever is not. This leads to the following behavior if a table has bothpositionandz-index:position, but az-indexofauto.z-index, butposition: static.This effectively means that the
z-indexproperty is ignored since it has no effect on non-positioned elements. This behavior contradicts what other browsers do and causes layout issues on websites.To align Ladybird behavior with other browser this commit also moves the
z-indexproperty to the wrapper box.Fixes #3533.