Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Added delegationmanagerstorage functions #564

Merged
merged 2 commits into from
Feb 13, 2025
Merged

Conversation

Sidu28
Copy link
Contributor

@Sidu28 Sidu28 commented Feb 12, 2025

Fixes # .

What Changed?

added delegationmanagerstorage functions

Reviewer Checklist

  • Code is well-documented
  • Code adheres to Go naming conventions
  • Code deprecates any old functionality before removing it

@Sidu28 Sidu28 marked this pull request as ready for review February 12, 2025 23:47
@Sidu28 Sidu28 requested a review from MegaRedHand February 12, 2025 23:47
@MegaRedHand
Copy link
Contributor

Remember to include a link to the open issue like: "Closes #526"

Copy link
Contributor

@MegaRedHand MegaRedHand left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Comment on lines +225 to +226
assert.NoError(t, err)
assert.False(t, isSpent)
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We should test the "true" case sometime in the future.

@MegaRedHand MegaRedHand added this pull request to the merge queue Feb 13, 2025
Merged via the queue into dev with commit 05e4069 Feb 13, 2025
11 checks passed
@MegaRedHand MegaRedHand deleted the delegationmanagerstorage branch February 13, 2025 16:23
@MegaRedHand MegaRedHand mentioned this pull request Feb 13, 2025
3 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants