-
Notifications
You must be signed in to change notification settings - Fork 14
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
replace rpi command "vcgencmd" with Linux command "sensors" #1
Open
bobwen-dev
wants to merge
9
commits into
MRsagi:master
Choose a base branch
from
bobwen-dev:master
base: master
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
MRsagi
reviewed
Mar 12, 2021
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Hey Bob Wen,
thank you for your contribution.
I'm no longer use cockpit on my server so I can't validate your changes.
I do trust you they work but I'd like if you can edit the readme.md and add pictures.
Thanks
I'm sorry I got back to you so late.
Recently I was unable to connect to the internet due to some national force majeure, the good news is that I am not completely restricted from personal freedom now, I'm back.
The experience of this time made me realize that there is a serious remote injection vulnerability in cockpit, run "cockpit.spawn()" in browser is a really bad mechanism.
I'll never use cockpit again. As an end, I uploaded the screenshots <https://github.com/bobwen-dev/cockpit-temperature-plugin/tree/master/screenshots>.
Mar 13, 2021, 04:44 by ***@***.***:
…
@MRsagi> commented on this pull request.
Hey Bob Wen,
thank you for your contribution.
I'm no longer use cockpit on my server so I can't validate your changes.
I do trust you they work but I'd like if you can edit the readme.md and add pictures.
Thanks
—
You are receiving this because you authored the thread.
Reply to this email directly, > view it on GitHub <#1 (review)>> , or > unsubscribe <https://github.com/notifications/unsubscribe-auth/ASSWY7SQGXO7AQBER5DBRGLTDJ4K5ANCNFSM4YZAK6SA>> .
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Replaced rpi command "vcgencmd" with Linux command "sensors";
Added i18n po files;