Run check_manifest

[maithuvenkatesh]

Checking the result of adding check-manifest to the the CI pipeline.

[jnothman]

check_manifest: command not found

Please install it first.

[jnothman]

Seems we're running it in the wrong directory...

[thomasjpfan]

This does not pass locally for me with:

lists of files in version control and sdist do not match!
missing from VCS:

which includes all the generated c files from Cython and generated py files used for deprecation.

[jnothman]

Is there a way to make "missing from VCS" non-fatal?

[thomasjpfan]

Not possible yet: mgedmin/check-manifest#58

We can try work around this by dynamically getting the files that are generated, which will be passed into --ignore.

[ogrisel]

We might still want to make it work and adapt it to the new CD infra in https://github.com/scikit-learn/scikit-learn/blob/master/.github/workflows/wheels.yml.

[thomasjpfan]

As a reference: There is a check-manfiest github action that runs daily on the main repo: https://github.com/scikit-learn/scikit-learn/blob/master/.github/workflows/check-manifest.yml