Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

opengl compatible Qt5 and Qt6 #242

Open
wants to merge 2 commits into
base: master
Choose a base branch
from
Open

opengl compatible Qt5 and Qt6 #242

wants to merge 2 commits into from

Conversation

wangdaye078
Copy link

No description provided.

mrbean-bremen
mrbean-bremen approved these changes Dec 2, 2024
View reviewed changes
Copy link
Contributor

@mrbean-bremen mrbean-bremen left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

As far as I can see this looks good, thanks! Though I would like that @usiems has another look.
You can ignore the failing tests for the OldSchool workflows, they are unrelated.

extensions/PythonQt_QtAll/PythonQt_QtAll.pro Outdated
@@ -115,6 +112,9 @@ PythonQtNetwork {
PythonQtOpengl {
DEFINES += PYTHONQT_WITH_OPENGL
QT += opengl
equals(QT_MAJOR_VERSION, 6){
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

maybe better use greaterThan(QT_MAJOR_VERSION, 5) here

@mrbean-bremen
Copy link
Contributor

Ping @usiems

@usiems
Copy link
Contributor

usiems commented Jan 17, 2025

Sorry for my late answer.
Of course these changes are correct in principle. What I don't like about them is that they would break backward compatibility to the previous PythonQt version, as some classes would now appear in PythonQt.QtOpenGL instead of PythonQt.QtGui.
Ideally these classes would appear in both packages: The new place, where they would be expected according to the Qt 6 documentation, and - perhaps optionally - the old place, so existing code doesn't need to be changed. I don't believe PythonQt currently supports this, and I don't know how much effort it would be to implement this.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mrbean-bremen mrbean-bremen mrbean-bremen approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@wangdaye078 @mrbean-bremen @usiems