Interrupt reloads when new files change #158
Conversation
DUX-1244 Interrupt reloads when new files change
This would help things feel a little snappier. Canceling tests would also be helpful, e.g. to implement Maybe we could have separate "cancel reloads" and "cancel tests" switches? Cancelling reloads might be a bit tricky — new files don't get loaded automatically, so we'd need to make sure nothing gets dropped. |
| ) -> miette::Result<T> { | ||
| // See: https://github.com/rust-lang/rust/pull/100737#issuecomment-1445257548 | ||
| let mut old_signal_mask = SigSet::empty(); | ||
| pthread_sigmask( |
There was a problem hiding this comment.
It turns out that this doesn't just stop ghci from inheriting SIGINT from ghciwatch, it also stops ghci from receiving SIGINT whatsoever.
This is a little messier, I guess — when users press Ctrl-C the underlying ghci session will see that as well — but then ghciwatch will shut down, so it doesn't matter much in the end.
9999years
force-pushed
the
rebeccat/dux-1244-interrupt-reloads-when-new-files-change
branch
from
c065514 to
6961855
Compare
9999years
added
minor
This will give a snappier UX in general. Note that now, many hooks can be canceled or mismatched (e.g. the before-reload hooks can run but the after-reload hooks get canceled).
9999years
force-pushed
the
rebeccat/dux-1244-interrupt-reloads-when-new-files-change
branch
from
6961855 to
3fea57a
Compare
| tokio::select! { | ||
| _ = handle.on_shutdown_requested() => { | ||
| // Cancel any in-progress reloads. This releases the lock so we don't block here. | ||
| task.abort(); | ||
| ghci.lock().await.stop().await.wrap_err("Failed to quit ghci")?; | ||
| break; | ||
| } | ||
| Some(new_event) = receiver.recv() => { |
There was a problem hiding this comment.
Might be worth explicitly matching on the Reload constructor of GhciEvent so that if you later add more constructors this will become a non-exhaustive pattern match.
9999years
deleted the
rebeccat/dux-1244-interrupt-reloads-when-new-files-change
branch
This will give a snappier UX in general.
Note that now, many hooks can be canceled or mismatched (e.g. the before-reload hooks can run but the after-reload hooks get canceled). I'm not sure if this will cause issues with Honeycomb (e.g. spans that open but don't close).