Fix release workflow with PRs from forks #332
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
PR #329 failed to create a release because the release workflow ran in the context of the fork: ``` Run peter-evans/create-pull-request@v5 Error: Input 'token' not supplied. Unable to continue. Restore git configuration Error: Cannot read properties of undefined (reading 'removeAuth') ``` Change the workflow to run in `pull_request_target` to fix this, I hope. Also update `get-crate-version` to not depend on any runtime tools, only the Nix expressions. See: https://github.com/MercuryTechnologies/ghciwatch/actions/runs/12130981516/job/33822389311
9999years
deleted the
wiggles/dux-2827-enable-releases-for-prs-from-forks
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
PR #329 failed to create a release because the release workflow ran in the context of the fork:
Change the workflow to run in
pull_request_targetto fix this, I hope.Also update
get-crate-versionto not depend on any runtime tools, only the Nix expressions.See: https://github.com/MercuryTechnologies/ghciwatch/actions/runs/12130981516/job/33822389311