Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[DUX-2822] Add --verbose, an alias for --log-filter ghciwatch=debug,info. #337

Draft
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

a-02
Copy link

@a-02 a-02 commented Jan 20, 2025

  • Labeled the PR with patch, minor, or major to request a version bump when it's merged.
  • Updated the user manual in docs/.
  • Added integration / regression tests in tests/.

I don't work here anymore, but this is still bugging me. Is this close to what you were wanting?

@github-actions github-actions bot added the patch Bug fixes or non-functional changes label Jan 20, 2025
@9999years
Copy link
Member

Unfortunately the clap alias functionality is pretty limited -- it can only make add aliases for an existing argument (I doubt this works as written, but it would make ----log-filter ghciwatch=debug,info work the same as --verbose if it did).

The actual code won't be that much more complex, we just need to create some logic for figuring out the log filters and then use that. It'll look something like this:

https://github.com/home-mangler/home-mangler/blob/a9faf62e8ebe5ebbe1950daf2fef8ef6dd64eef4/src/cli.rs#L68-L86

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
patch Bug fixes or non-functional changes
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants