feat(module:check-list): add check-list component #8969
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This comment was marked as outdated.
This comment was marked as outdated.
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #8969 +/- ##
==========================================
+ Coverage 91.91% 91.95% +0.03%
==========================================
Files 555 559 +4
Lines 19708 19766 +58
Branches 2944 2948 +4
==========================================
+ Hits 18114 18175 +61
+ Misses 1267 1264 -3
Partials 327 327 ☔ View full report in Codecov by Sentry. |
OriginRing
force-pushed
the
feat/check-list
branch
2 times, most recently
from
725fc04 to
ded0fa4
Compare
This comment was marked as duplicate.
This comment was marked as duplicate.
OriginRing
force-pushed
the
feat/check-list
branch
from
ded0fa4 to
7c8889f
Compare
OriginRing
changed the title
OriginRing
force-pushed
the
feat/check-list
branch
4 times, most recently
from
c08c341 to
9a2bb62
Compare
OriginRing
force-pushed
the
feat/check-list
branch
from
9a2bb62 to
64e0fdc
Compare
OriginRing
force-pushed
the
feat/check-list
branch
from
64e0fdc to
7fd13e8
Compare
Comment on lines
+18
to
+23
| @if (!!triggerRender) { | ||
| <ng-container *nzStringTemplateOutlet="triggerRender">{{ triggerRender }}</ng-container> | ||
| } @else { | ||
| <span nz-icon nzType="check-circle" nzTheme="outline" class="ant-check-list-icon"></span> | ||
| <div class="ant-check-list-description">{{ locale.checkList }}</div> | ||
| } |
There was a problem hiding this comment.
- 优先使用
<ng-content>而不是传递 templateRef - 使用
<nz-icon>而不是<span nz-icon>
Suggested change
| @if (!!triggerRender) { | |
| <ng-container *nzStringTemplateOutlet="triggerRender">{{ triggerRender }}</ng-container> | |
| } @else { | |
| <span nz-icon nzType="check-circle" nzTheme="outline" class="ant-check-list-icon"></span> | |
| <div class="ant-check-list-description">{{ locale.checkList }}</div> | |
| } | |
| <ng-content> | |
| <nz-icon nzType="check-circle" nzTheme="outline" class="ant-check-list-icon" /> | |
| <div class="ant-check-list-description">{{ locale.checkList }}</div> | |
| </ng-content> |
| @if (progress) { | ||
| <div class="ant-check-list-progressBar"> | ||
| <div class="ant-check-list-progressBar-progress"> | ||
| <nz-progress [nzPercent]="getPercent() | number: '1.0-0'"></nz-progress> |
There was a problem hiding this comment.
对于新组件，我们是否应该使用 signals API 来简化代码/提高性能？ @Laffery
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
PR Checklist
Please check if your PR fulfills the following requirements:
PR Type
What kind of change does this PR introduce?
What is the current behavior?
Issue Number: N/A
What is the new behavior?
Does this PR introduce a breaking change?
Other information