Avoid using cuhpx for nest and XY reordering #22
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
cuhpx is not open source yet and can be challenging to install. the conversions between nest and xy pixel ordering are all vectorized pytorch code so we don't need cuhpx for that. I have also confirmed that torch.compile is able to correctly fuse the index conversion and array loading, so this should be as fast as a hand implementation in cuda.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
cuhpx is not released yet and can be challenging to install.
the conversions between nest and xy pixel ordering are all vectorized
pytorch code so we don't need cuhpx for that. I have also confirmed that
torch.compile is able to correctly fuse the index conversion and array
loading, so this should be as fast as a hand implementation in cuda.