Change earth2-grid to earth2grid

[oliverwm1]

Trying to resolve this issue I got when installing package directly from git url.

Using Python 3.10.16 environment at: /opt/homebrew/Caskroom/miniconda/base/envs/fme
  × Failed to download and build `earth2grid @ git+https://github.com/NVlabs/[email protected]`
  ╰─▶ Package metadata name `earth2-grid` does not match given name `earth2grid`

[oliverwm1]

@nbren12 can this get merged? It resolves the issue I note in the PR description above.

[nbren12]

Thanks for fixing the github link, but would be interested to know if you can resolve the issue without renaming the package from earth2-grid to earth2grid, since I'm worried this change could break somebody else's workflow.

Would fixing the name in you requirements.txt or setup.py to earth2-grid fix this? .e.g.

earth2-grid @ git+https://github.com/NVlabs/[email protected]

[oliverwm1]

Thanks for fixing the github link, but would be interested to know if you can resolve the issue without renaming the package from earth2-grid to earth2grid, since I'm worried this change could break somebody else's workflow.

Will try. Although I expect the inconsistency would continue to confuse users/lead to this issue cropping up again in the future. The name would still be earth2-grid for older versions of the package, so as long as downstream packages have version pinned, it seems like it would be okay?

[nbren12]

Although I expect the inconsistency would continue to confuse users/lead to this issue cropping up again in the future.

If you think it would make a big difference, I'm open, but removing a "-" in a package name is pretty common in python

• scikit-learn -> sklearn
• python-dotenv -> dotenv

[oliverwm1]

Would fixing the name in you requirements.txt or setup.py to earth2-grid fix this? .e.g.

Thanks, this worked.

If you think it would make a big difference, I'm open, but removing a "-" in a package name is pretty common in python

Up to you... given the name of this repo, I do think the earth2-grid is more confusing than the examples you provide. This change would make the package noticeably easier to use IMO.

[nbren12]

Glad it worked. I agree earth2-grid is the odd ball out given the repo name. And the repo name is harder to change. So after some back and forth you convinced me. 😊 I’ll merge.

[nbren12]

Actually, @oliverwm1. Sorry but I have a bit of red tape for you. Can you sign-off on the commit git commit -s and re-push? This ensures you are good with the DCO.

[oliverwm1]

Sure thing. Good iwth 9a54662 ?

[nbren12]

Technically I think every commit has to be signed off for external contribution. But something like

git reset --soft origin/main
git commit -s -m "your message"
git push --force origin HEAD

should work.

Sorry for the trouble.

[nbren12]

🐹 🛞

[oliverwm1]

Hah. Yeah the amend didn't work. This seemed easier: #26