Fix: set value to null when clearing from a single select select2 and null check in ngOnDestroy

[tjwoods58]

Closes #61

[piernik]

Is this fix gonna be published?

[ricavir11]

Hi, I'm also wondering when this fix will be published... It would be great !

[MarkHerhold]

@NejcZdovc Do you have any plans to merge this?

[NejcZdovc]

@MarkHerhold did you try out hits patch? Is it working for you with this fix?

[MarkHerhold]

@NejcZdovc Partially. I can't directly reproduce the issue but I know that the if check will only prevent potential errors. I would actually go further than this PR does and check that off is a function and not just that it exists.

I can't comment on the other portion of this PR as we don't have issues with the select/unselect events.

I will submit a PR that only adds the if check as that's what I can validate and I know it's a safe change. Are you OK with this @NejcZdovc ?

[NejcZdovc]

@MarkHerhold sounds good

[sbanerjee302]

@NejcZdovc can you please merge this fix also ? facing a similar issue.

[NejcZdovc]

@sbanerjee302 can you please test this PR out and confirm that it's working correctly

[sbanerjee302]

@NejcZdovc The null check in ngOnDestroy is definitely working which was the issue I was facing.

[NejcZdovc]

@MarkHerhold said that he will do a pr just for this null check, so we can merge that one

[sbanerjee302]

@NejcZdovc I have created a PR for the null check and also added a check if the off function exists. Can you please review.

[NejcZdovc]

@sbanerjee302 done, merged and new version published [email protected]