Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Removes http-server #160

Merged
merged 1 commit into from
Feb 2, 2024
Merged

Removes http-server #160

merged 1 commit into from
Feb 2, 2024

Conversation

klebba
Copy link
Collaborator

@klebba klebba commented Feb 2, 2024

Addresses #158

@klebba klebba requested a review from theengineear February 2, 2024 02:57
@klebba klebba force-pushed the remove-http-server branch from f5e79f5 to d7e658a Compare February 2, 2024 02:59
Copy link
Collaborator Author

@klebba klebba Feb 2, 2024

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

These 100 lines eliminate the need for a vast trove of dependencies (33 to be exact)

Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Ah awesome — love this change.

theengineear
theengineear previously approved these changes Feb 2, 2024
Copy link
Collaborator

@theengineear theengineear left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for slimming down the dev deps here 🙏

@klebba
Copy link
Collaborator Author

klebba commented Feb 2, 2024

Todo -- .md mime type

@klebba klebba force-pushed the remove-http-server branch 2 times, most recently from 7d7013c to 6a43fc9 Compare February 2, 2024 06:59
@klebba klebba requested a review from theengineear February 2, 2024 06:59
@klebba
Copy link
Collaborator Author

klebba commented Feb 2, 2024

Rebased

@klebba klebba force-pushed the remove-http-server branch from 6a43fc9 to efd41ba Compare February 2, 2024 07:07
Copy link
Collaborator

@theengineear theengineear left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@klebba klebba merged commit 678bca5 into main Feb 2, 2024
1 check passed
@klebba klebba deleted the remove-http-server branch February 2, 2024 18:39
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants