Fix test runner, smarter server #168
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
klebba
commented
Feb 13, 2024
|
|
||
| server.listen(process.env.PORT || 8080, () => { | ||
| const { address, port } = server.address(); | ||
| Server.origin = `http://[${address}]:${port}`; |
There was a problem hiding this comment.
We use introspection to generate the origin component necessary to qualify the path and leverage URL above for smarter path parsing.
| static requestListener(request, response) { | ||
| if (request.method === 'GET') { | ||
| const fileUrl = request.url; | ||
| const filePath = path.resolve(`${root}/${fileUrl}`); | ||
| const url = new URL(request.url, Server.origin); |
There was a problem hiding this comment.
By adopting URL here we can easily extract pathname and fix the confusion around paths which incorporate query params. Easy peasy.
klebba
commented
Feb 13, 2024
| @@ -3,7 +3,17 @@ import puppeteer from 'puppeteer'; | |||
| (async () => { | |||
| try { | |||
| // Open our browser. | |||
| const browser = await puppeteer.launch({ timeout: 10000 }); | |||
| const browser = await puppeteer.launch({ | |||
There was a problem hiding this comment.
These are just a few flags I borrowed from another project (Profiler)
| timeout: 10000, | ||
| // opt-in to the new Chrome headless implementation | ||
| // ref: https://developer.chrome.com/articles/new-headless/ | ||
| headless: 'new', |
There was a problem hiding this comment.
Oh, we using the new, new. Cool.
| args: [ | ||
| // Disables interactive prompt: Do you want to the application Chromium.app to accept incoming network connections? | ||
| // ref: https://github.com/puppeteer/puppeteer/issues/4752#issuecomment-586599843 | ||
| '--disable-features=DialMediaRouteProvider', |
theengineear
approved these changes
Feb 13, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #167