Leverage error “cause” for wrapping render errors. #170
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Because some template engines can throw _immutable_ errors, it’s safer and better to use an “error cause” to _chain_ the old error to our own versus trying to mutate the original. Closes #128.
theengineear
commented
Feb 13, 2024
| @@ -123,8 +123,8 @@ export default class XElement extends HTMLElement { | |||
| render(renderRoot, result); | |||
| } catch (error) { | |||
| const pathString = XElement.#toPathString(this); | |||
| error.message = `${error.message} — Invalid template for "${this.constructor.name}" at path "${pathString}"`; | |||
| throw error; | |||
| const message = `${error.message} — Invalid template for "${this.constructor.name}" at path "${pathString}"`; | |||
There was a problem hiding this comment.
Note, for now, we continue to embed the original error message. Eventually, we can simply remove it once the tooling catches up — see #169.
|
FYI @klebba — super small change to leverage error “cause”. It’s a slightly safer way of wrapping errors. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Because some template engines can throw immutable errors, it’s safer and better to use an “error cause” to chain the old error to our own versus trying to mutate the original.
Closes #128.