Additional updates for “2.x” release. #213
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
theengineear
commented
Nov 19, 2024
| | -- | -- | `el.removeAttribute('foo'); // if “bar” is nullish` | | ||
| | property | `<div .foo="${bar}"></div>` | `el.foo = bar;` | | ||
| | content | `<div>${foo}</div>` | `el.append(document.createTextNode(foo)) // if “bar” is text` | | ||
| | -- | -- | (see [content binding](#content-binding) for composition) | |
There was a problem hiding this comment.
Made the table a bit more wide so that the emulation code is proximal to the template code.
theengineear
commented
Nov 19, 2024
test/test-template-engine.js
Outdated
| @@ -564,7 +564,7 @@ describe('html updaters', () => { | |||
|
|
|||
| it('unsafe html', () => { | |||
| const getTemplate = ({ content }) => { | |||
| return html`<div id="target">${unsafe(content, 'html')}</div>`; | |||
| return html`<div id="target">${unsafe(content)}</div>`; | |||
There was a problem hiding this comment.
The unsafe updater gets much more simple.
theengineear
commented
Nov 19, 2024
| @@ -1476,28 +1451,10 @@ describe('rendering errors', () => { | |||
|
|
|||
|
|
|||
| describe('unsafe', () => { | |||
| it('throws if used on an unexpected language', () => { | |||
There was a problem hiding this comment.
We don’t support unsafe svg for now. We may choose to add this back in the future in some backwards-compatible way.
|
FYI — @klebba. |
theengineear
force-pushed
the
ready-2x-interface
branch
from
b6050d7 to
bc23055
Compare
theengineear
commented
Nov 19, 2024
x-element.js
Outdated
| // the template “strings” before, we also have to generate html, parse it, | ||
| // and find out binding targets. Then, we commit the values by iterating over | ||
| // our targets. Finally, we actually attach our new DOM into our node. | ||
| static #inject(result, node, before) { |
There was a problem hiding this comment.
@klebba — Did some refactoring / renaming here since you called it out as confusing when you were looking things over yesterday. Hope it helps!
theengineear
commented
Nov 19, 2024
x-element.js
Outdated
| TemplateEngine.#ready(result); | ||
| TemplateEngine.#commit(result); | ||
| TemplateEngine.#inject(result, node, { before: true }); | ||
| TemplateEngine.#inject(result, node, true); |
There was a problem hiding this comment.
The ready + commit + inject methods are collapsed into a single inject method now.
theengineear
commented
Nov 19, 2024
x-element.js
Outdated
| state.result = result; | ||
| } else { | ||
| TemplateEngine.#assign(state.result, result); | ||
| TemplateEngine.#commit(state.result); | ||
| TemplateEngine.#update(state.result, result); |
There was a problem hiding this comment.
The assign + commit methods are collapsed into a single update method now.
theengineear
force-pushed
the
ready-2x-interface
branch
from
bc23055 to
69c8936
Compare
theengineear
changed the title
theengineear
force-pushed
the
ready-2x-interface
branch
4 times, most recently
from
9b6a42a to
f8bc37d
Compare
theengineear
force-pushed
the
ready-2x-interface
branch
from
f8bc37d to
9460060
Compare
Changes: * Deprecate `unsafeHTML` and `usafeSVG`. * Allow binding `DocumentFragment` as a value. * Tag every line in the “CHANGELOG.md” with an issue ticket. * Simplified formatting related to bindings in “TEMPLATES.md”. * Emit deprecation warnings for soon-to-be-gone interfaces. * Deprecate remaining updaters (e.g., “map”). * Ditch unecessary “weak maps”.† * Some performance improvements. † The search set for the weak maps we’re using gets untenable since it’s a flat list of pointers for _all_ results. It feels like a reasonable concession to hang data off of a unique symbol key. These are non-enumerable (unless specifically trying to enumerate symbols), which feels internal enough. Additionally, returning the values passed in by the user doesn’t feel like much of a leaking abstraction.
theengineear
force-pushed
the
ready-2x-interface
branch
from
9460060 to
19367eb
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Additional updates for “2.x” release.
Changes:
unsafeHTMLandusafeSVG.DocumentFragmentas a value.† The search set for the weak maps we’re using gets untenable since it’s
a flat list of pointers for all results. It feels like a reasonable
concession to hang data off of a unique symbol key. These are
non-enumerable (unless specifically trying to enumerate symbols),
which feels internal enough. Additionally, returning the values passed
in by the user doesn’t feel like much of a leaking abstraction.