Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Split out template engine into “x-template.js”. #227

Merged
merged 1 commit into from
Dec 5, 2024
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension


Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 2 additions & 0 deletions CHANGELOG.md
Original file line number Diff line number Diff line change
Expand Up @@ -29,6 +29,8 @@ and this project adheres to [Semantic Versioning](https://semver.org/spec/v2.0.0
- You may now bind values of type `DocumentFragment` within the template engine.
In particular, this was added to enable advanced flows without needing to
bloat the default template engine interface (#207, #216).
- Pull “x-template.js” into a separate file. Conceptually it solves a totally
different problem than “x-element” (#226).

### Deprecated

Expand Down
19 changes: 12 additions & 7 deletions deno.json
Original file line number Diff line number Diff line change
Expand Up @@ -2,17 +2,22 @@
"name": "@netflix/x-element",
"version": "1.1.1",
"exports": {
"./x-element.js": "./x-element.js",
"./x-element.d.ts": "./x-element.d.ts",
"./x-element.js": "./x-element.js",
"./x-template.js": "./x-template.js",
"./etc/ready.js": "./etc/ready.js",
"./etc/ready.d.ts": "./etc/ready.d.ts"
"./ts/x-element.d.ts": "./ts/x-element.d.ts",
"./ts/x-template.d.ts": "./ts/x-template.d.ts",
"./ts/etc/ready.d.ts": "./ts/etc/ready.d.ts"
},
"include": [
"./x-element.js",
"./x-element.d.ts",
"./x-element.d.ts.map",
"./x-template.js",
"./etc/ready.js",
"./etc/ready.d.ts",
"./etc/ready.d.ts.map"
"./ts/x-element.d.ts",
"./ts/x-element.d.ts.map",
"./ts/x-template.d.ts",
"./ts/x-template.d.ts.map",
"./ts/etc/ready.d.ts",
"./ts/etc/ready.d.ts.map"
]
}
2 changes: 1 addition & 1 deletion eslint.config.js
Original file line number Diff line number Diff line change
Expand Up @@ -11,7 +11,7 @@ export default [
ignores: ['server.js', 'test.js'],
},
{
files: ['x-element.js', 'etc/ready.js'],
files: ['x-element.js', 'x-template.js', 'etc/ready.js'],
plugins: { jsdoc },
rules: {
'jsdoc/require-param-description': 'off',
Expand Down
1 change: 0 additions & 1 deletion etc/ready.d.ts.map

This file was deleted.

Loading
Loading