[Wallet Extension] mvp0 implementation #58
Conversation
0xAleksaOpacic
force-pushed
the
feature/wallet-extension-mvp0
branch
from
6e41825 to
7d59559
Compare
|
|
||
| --- | ||
|
|
||
| ## How to Use ⚙️ |
There was a problem hiding this comment.
should readme be adopted to monorepo or its like a local readme for wallet only?
There was a problem hiding this comment.
I personally feel that some of these integrations like wallet, even if they are in the same monorepo should have their "root" readme, as putting everything in the main root readme will crate too much data
wallet-extension/package-lock.json
Outdated
There was a problem hiding this comment.
from my pov better to include wallet to workspaces and avoid having this lockfile. npm packages will be reused if we include wallet to workspaces.
wallet-extension/package.json
Outdated
| "interface": "i18next-resources-for-ts interface -i public/locales/en -o src/@types/resources.d.ts" | ||
| }, | ||
| "dependencies": { | ||
| "@nilfoundation/niljs": "^0.22.0", |
There was a problem hiding this comment.
this will also be reused form the local repo which is quite useful for development purposes. and remove ^ cause currently we support only latest versions of the packages.
There was a problem hiding this comment.
Ofc, you are completely right. I was waiting for latest release, as the code deployed then was not ocmpatible with latest nil.js. Adapting it now
| // Get all activities for a specific wallet | ||
| export const getActivities = async (walletAddress: string): Promise<Activity[]> => { | ||
| const storageKey = getStorageKey(walletAddress); | ||
| const result = await chrome.storage.local.get(storageKey); |
There was a problem hiding this comment.
what is the purpose of using this chrome wrapper? it is some safe limited browser api access?
There was a problem hiding this comment.
chrome.storage.local is a part of the Chrome Extensions API, designed specifically for extensions to securely store and retrieve data. Unlike localStorage, it is asynchronous and allows larger storage limits (up to 5MB by default, compared to 5-10MB in localStorage). It is isolated from regular web pages, meaning websites cannot access extension data. This makes it safer and more suitable for browser extensions where privacy and controlled data access are important.
| if (blockchainFields) { | ||
| console.log("Loaded blockchain fields from storage: ", blockchainFields); | ||
|
|
||
| const { rpcEndpoint, shardId, privateKey, walletAddress } = blockchainFields; |
There was a problem hiding this comment.
strange that you don't need to JSON.parse() cz local storage stores everything as strings.
There was a problem hiding this comment.
chrome.storage.local.get() automatically handles JSON serialization and deserialization
|
|
||
| export async function fetchBalance(wallet: WalletV1): Promise<bigint> { | ||
| try { | ||
| return await wallet.getBalance(); |
There was a problem hiding this comment.
You caught me 😂 I opened pr before refactor i probably should go over it and see if i need to rename somewhere else
There was a problem hiding this comment.
| ): Promise<string> { | ||
| try { | ||
| console.log(`Topping up wallet with ${amountEth} ETH...`); | ||
| const faucet = new Faucet(client); |
There was a problem hiding this comment.
this Faucet is deprecated and is a subject to be removed in the next versions
There was a problem hiding this comment.
0xAleksaOpacic
force-pushed
the
feature/wallet-extension-mvp0
branch
from
7d59559 to
5245c13
Compare
0xAleksaOpacic
force-pushed
the
feature/wallet-extension-mvp0
branch
from
5245c13 to
69753d2
Compare
0xAleksaOpacic
force-pushed
the
feature/wallet-extension-mvp0
branch
from
69753d2 to
84a946e
Compare
0xAleksaOpacic
force-pushed
the
feature/wallet-extension-mvp0
branch
from
f9f8fe6 to
1fb8616
Compare
0xAleksaOpacic
force-pushed
the
feature/wallet-extension-mvp0
branch
from
1fb8616 to
e4ad692
Compare
0xAleksaOpacic
force-pushed
the
feature/wallet-extension-mvp0
branch
from
e4ad692 to
bd2bf20
Compare
0xAleksaOpacic
force-pushed
the
feature/wallet-extension-mvp0
branch
from
b29e6fa to
4200653
Compare
0xAleksaOpacic
force-pushed
the
feature/wallet-extension-mvp0
branch
from
4200653 to
c77aae3
Compare
PR Description
This PR is quite large—apologies in advance to anyone who has to review it! It covers the implementation of MVP0 for our wallet extension, ultimately providing a working production version to share with our community.
The PR is broken down into four parts:
nil.js(Done)After merging, we’ll have a functional wallet extension ready for community feedback and usage.
Local Development
If you want to run this extension locally:
npm run build.It’s pretty straightforward! You can also check out this helpful guide on testing a browser extension locally.