Fixed explorer assign tab contract duplication bug #70
+68
−24
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This was referenced Feb 3, 2025
gitshreevatsa
force-pushed
the
explorerBugs
branch
from
9ed8917 to
dde9457
Compare
ukorvl
reviewed
Feb 3, 2025
| import { useStyletron } from "styletron-react"; | ||
| import { $smartAccount } from "../../../account-connector/model"; | ||
| import { | ||
| $assignedSmartContractAddress, | ||
| $state, |
There was a problem hiding this comment.
can you plz rename this? state is a meaningless name which is quite not good practice. imagine you are going to have another similar entity - how to name it - state2?
There was a problem hiding this comment.
I have renamed it with deployedContracts because the variable is a store that holds contracts code with array of addresses, post deployment.
ukorvl
approved these changes
Feb 3, 2025
gitshreevatsa
force-pushed
the
explorerBugs
branch
from
49a6789 to
5d91364
Compare
ukorvl
changed the title
This was
linked to
issues
Feb 3, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Changed AssignTab explicitly to disallow duplication of contracts and clearing of address on modal close.