[16.0][FIX] account_move_line_purchase_info: do not consider stock entry lines on revaluations #2018
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
AlexPForgeFlow
force-pushed
the
16.0-imp-account_move_line_purchase_info
branch
8 times, most recently
from
19b9e52 to
2d9cdfe
Compare
…try lines on revaluations Up to now, stock entries were considered in the revaluation process as they were stored on field invoice_lines. To avoid that we introduced a dedicated field to manage stock entries and avoid taking them into account in the revaluation odoo core process.
AlexPForgeFlow
force-pushed
the
16.0-imp-account_move_line_purchase_info
branch
from
2d9cdfe to
c98562c
Compare
| @@ -33,6 +33,13 @@ This module will add the purchase order line to journal items. | |||
| The ultimate goal is to establish the purchase order line as one of the key | |||
| fields to reconcile the Goods Received Not Invoiced accrual account. | |||
|
|
|||
| Field purchase_line_id_oca it's necessary. In Odoo >=16 automatic | |||
There was a problem hiding this comment.
Suggested change
| Field purchase_line_id_oca it's necessary. In Odoo >=16 automatic | |
| Field purchase_line_id_oca is necessary. In Odoo >=16 automatic |
| Field purchase_line_id_oca it's necessary. In Odoo >=16 automatic | ||
| revaluation for a product with FIFO costing method only works if invoice | ||
| lines related to a purchase order line do not include stock journal items. | ||
| To aviod that purchase_line_id_oca includes invoice and stock journal items, |
There was a problem hiding this comment.
Suggested change
| To aviod that purchase_line_id_oca includes invoice and stock journal items, | |
| To avoid that purchase_line_id_oca includes invoice and stock journal items, |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Issue: #2017
Up to now, stock entries were considered in the revaluation process as they were stored on field invoice_lines. To avoid that we introduced a dedicated field to manage stock entries and avoid taking them into account in the revaluation odoo core process.