Force the DDS/DXT stream decompression. #3291
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The DDSCodec keeps the DXT format if the hardware supports it. However using this stack object it is possible to enforce the DXT decompression into RGB(A) format. This is useful e.g. when we have DDS texture without mipmaps and we need them. DirectX11 does not generate mipmaps if the texture is compressed (DirectX9 does it automatically). Also added support to obtain the DDS stream (not only saving to file).
paroj
reviewed
Feb 21, 2025
| The DDSCodec keeps the DXT format if the hardware supports it. | ||
| However this stack object can enforce the DXT decompression into RGB(A) format. | ||
| */ | ||
| class _OgreExport DDSDecodeEnforcer |
There was a problem hiding this comment.
You are in a private header here which is not accessible for client code.
Please add a generic virtual setParameter method to Codec like this:
ogre/Components/RTShaderSystem/include/OgreShaderSubRenderState.h
Lines 161 to 162 in 57fc7df
and override it in DDSCodec. You can create a stack object based on this in your application code.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The DDSCodec keeps the DXT format if the hardware supports it. However using this stack object it is possible to enforce the DXT decompression into RGB(A) format. This is useful e.g. when we have DDS texture without mipmaps and we need them. DirectX11 does not generate mipmaps if the texture is compressed (DirectX9 does it automatically).
Also added support to obtain the DDS stream (not only saving to file).