Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Rework tests #473

Merged
merged 14 commits into from
Dec 7, 2023
Merged

Rework tests #473

merged 14 commits into from
Dec 7, 2023

Conversation

AlekseySh
Copy link
Contributor

No description provided.

@AlekseySh AlekseySh self-assigned this Dec 6, 2023
@AlekseySh
Copy link
Contributor Author

Changelog:

  • Starting now we will be running tests for all the supported pythons, instead of only for 3.8 to have better coverage. We will run short_tests for pull_request and long tests for push requests. Tests are running outside of docker, on the CI Ubuntu machine.

  • To avoid excessive checkpoints downloading from Zoo for every Python version, this test is executed only when a special global env is provided: DOWNLOAD_ZOO_IN_TESTS=yes. So, we provide this env only for one of the Python versions from the whole list.

  • We keep all_tests running in docker only for one Python version and only for push requests. It's done to avoid the need to maintain ~3-5 docker containers for every Python version and to save the time needed for every docker build.

  • Marked a number of tests as long to make short_tests even shorter (not all of them are really "long", but it seems unlikely that we need to run all of them on every commit)

  • Requirements needed for testing (pre-commit and pytest) are in one place and re-used in workflows & dockerfile

@AlekseySh AlekseySh requested a review from DaloroAT December 6, 2023 19:48
@AlekseySh AlekseySh merged commit 7d01449 into main Dec 7, 2023
6 checks passed
@AlekseySh AlekseySh deleted the rework_tests branch December 7, 2023 09:23
Copy link
Collaborator

@DaloroAT DaloroAT left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

What tests are not long? 😁

.github/workflows/docker_tests.yaml Show resolved Hide resolved
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Status: Done
Development

Successfully merging this pull request may close these issues.

2 participants