-
Notifications
You must be signed in to change notification settings - Fork 18
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Allow the Kubernetes agent to be registered with a pre-install hook #1057
Open
liam-mackie
wants to merge
11
commits into
main
Choose a base branch
from
lm/pre-install-script-k8s-agent
base: main
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
90cd881
to
6269c10
Compare
eddymoulton
reviewed
Feb 6, 2025
source/Octopus.Tentacle/Commands/MigratePreInstalledKubernetesDeploymentTargetCommand.cs
Outdated
Show resolved
Hide resolved
.../Octopus.Tentacle.Tests/Commands/MigratePreInstalledKubernetesDeploymentTargetCommandTest.cs
Outdated
Show resolved
Hide resolved
source/Octopus.Tentacle/Commands/MigratePreInstalledKubernetesDeploymentTargetCommand.cs
Outdated
Show resolved
Hide resolved
source/Octopus.Tentacle/Commands/MigratePreInstalledKubernetesDeploymentTargetCommand.cs
Outdated
Show resolved
Hide resolved
...ubernetes.Tests.Integration/KubernetesAgent/KubernetesAgentMigrateFromPreinstallationTest.cs
Outdated
Show resolved
Hide resolved
...ubernetes.Tests.Integration/KubernetesAgent/KubernetesAgentMigrateFromPreinstallationTest.cs
Show resolved
Hide resolved
...ubernetes.Tests.Integration/KubernetesAgent/KubernetesAgentMigrateFromPreinstallationTest.cs
Outdated
Show resolved
Hide resolved
...ubernetes.Tests.Integration/KubernetesAgent/KubernetesAgentMigrateFromPreinstallationTest.cs
Outdated
Show resolved
Hide resolved
...ubernetes.Tests.Integration/KubernetesAgent/KubernetesAgentMigrateFromPreinstallationTest.cs
Outdated
Show resolved
Hide resolved
c8d93ec
to
1a28ce6
Compare
eddymoulton
approved these changes
Feb 13, 2025
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Couple of small test things but other wise looks good
.../Octopus.Tentacle.Tests/Commands/MigratePreInstalledKubernetesDeploymentTargetCommandTest.cs
Outdated
Show resolved
Hide resolved
.../Octopus.Tentacle.Tests/Commands/MigratePreInstalledKubernetesDeploymentTargetCommandTest.cs
Outdated
Show resolved
Hide resolved
.../Octopus.Tentacle.Tests/Commands/MigratePreInstalledKubernetesDeploymentTargetCommandTest.cs
Outdated
Show resolved
Hide resolved
5e079f0
to
3f1483f
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Background
As a part of the Kubernetes Monitor, we need to have the Kubernetes agent registered prior to the agent registering with server. To do this, we need to run a pre-installation script.
To keep this backwards-compatible, we can't touch any existing resources, or helm may delete files that have data in them.
As such, we have opted for the pre-installation hook to write the configuration to a different configmap and secret, and have created a new command in tentacle to migrate the configuration to the final destination.
Results
register.sh
which only runs the registration commands.There should be no change to existing behaviour without additional changes to the helm chart to enable it.
I've also fixed up some of the integration tests to escape paths that may have spaces to fix issues running them on MacOS.
How to review this PR
Quality ✔️
Pre-requisites