-
Notifications
You must be signed in to change notification settings - Fork 8
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Use pydantic
> 1
#192
base: main
Are you sure you want to change the base?
Use pydantic
> 1
#192
Conversation
Try un-pinning `pydantic` and allowing it to be pinned by other packages as needed.
Getting weird solves; trying to address this.
Looks like we may be getting blocked by I've raised an issue on the |
Otherwise, all tests passing when I run locally. 😁 |
Getting weird hangs on the test suite in CI, but I can't reproduce the hangs locally. 🥲 |
If you want to test against upcoming versions of the OpenFF stack with natively pydantic 2 objects, you can grab the OpenFF stack from the |
We can switch wholly to |
Needed to use "before" validation in many cases, since we either want to validate inputs before model is instantiated or we want to modify those inputs before model is instantiated.
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #192 +/- ##
==========================================
- Coverage 80.15% 80.05% -0.11%
==========================================
Files 26 26
Lines 3472 3479 +7
==========================================
+ Hits 2783 2785 +2
- Misses 689 694 +5 ☔ View full report in Codecov by Sentry. |
Try un-pinning
pydantic
and allowing it to be pinned by other packages as needed.