Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use pydantic > 1 #192

Open
wants to merge 24 commits into
base: main
Choose a base branch
from
Open

Use pydantic > 1 #192

wants to merge 24 commits into from

Conversation

dotsdl
Copy link
Member

@dotsdl dotsdl commented Oct 12, 2023

Try un-pinning pydantic and allowing it to be pinned by other packages as needed.

@dotsdl
Copy link
Member Author

dotsdl commented Nov 9, 2023

Looks like we may be getting blocked by gufe, which currently requires openff-models 0.5.0: https://github.com/openforcefield/alchemiscale/actions/runs/6807892430/job/18511450355?pr=192#step:3:39

I've raised an issue on the gufe-feedstock to address: conda-forge/gufe-feedstock#30

@dotsdl
Copy link
Member Author

dotsdl commented Nov 9, 2023

Otherwise, all tests passing when I run locally. 😁

@dotsdl
Copy link
Member Author

dotsdl commented Dec 15, 2023

Getting weird hangs on the test suite in CI, but I can't reproduce the hangs locally. 🥲

@j-wags
Copy link

j-wags commented Oct 1, 2024

If you want to test against upcoming versions of the OpenFF stack with natively pydantic 2 objects, you can grab the OpenFF stack from the conda-forge/label/openff-interchange_rc on conda, more details at https://github.com/openforcefield/openff-toolkit/pull/1930/files

@dotsdl
Copy link
Member Author

dotsdl commented Jan 21, 2025

We can switch wholly to pydantic v2 as of gufe 1.3, once this PR goes in: OpenFreeEnergy/gufe#397

Needed to use "before" validation in many cases, since we either want to
validate inputs before model is instantiated or we want to modify those
inputs before model is instantiated.
Copy link

codecov bot commented Jan 22, 2025

Codecov Report

Attention: Patch coverage is 81.57895% with 7 lines in your changes missing coverage. Please review.

Project coverage is 80.05%. Comparing base (c32f00d) to head (2776119).

Files with missing lines Patch % Lines
alchemiscale/security/models.py 64.28% 5 Missing ⚠️
alchemiscale/security/auth.py 33.33% 2 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main     #192      +/-   ##
==========================================
- Coverage   80.15%   80.05%   -0.11%     
==========================================
  Files          26       26              
  Lines        3472     3479       +7     
==========================================
+ Hits         2783     2785       +2     
- Misses        689      694       +5     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Status: Sprint - In Review
Development

Successfully merging this pull request may close these issues.

3 participants