-
Notifications
You must be signed in to change notification settings - Fork 590
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
NMS-16359: Fix Device config backup with EddSA #7624
base: develop
Are you sure you want to change the base?
Conversation
...ipting/src/main/java/org/opennms/features/deviceconfig/sshscripting/impl/EdDSAActivator.java
Outdated
Show resolved
Hide resolved
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
We also need to evaulate this on Minion, might need changes on config.properties on Minion as well.
...ipting/src/main/java/org/opennms/features/deviceconfig/sshscripting/impl/EdDSAActivator.java
Outdated
Show resolved
Hide resolved
...ipting/src/main/java/org/opennms/features/deviceconfig/sshscripting/impl/EdDSAActivator.java
Outdated
Show resolved
Hide resolved
...ipting/src/main/java/org/opennms/features/deviceconfig/sshscripting/impl/EdDSAActivator.java
Outdated
Show resolved
Hide resolved
...ipting/src/main/java/org/opennms/features/deviceconfig/sshscripting/impl/EdDSAActivator.java
Outdated
Show resolved
Hide resolved
...g/src/main/java/org/opennms/features/deviceconfig/sshscripting/impl/CustomEddsaProvider.java
Outdated
Show resolved
Hide resolved
...g/src/main/java/org/opennms/features/deviceconfig/sshscripting/impl/CustomEddsaProvider.java
Outdated
Show resolved
Hide resolved
features/device-config/ssh-scripting/src/main/resources/OSGI-INF/blueprint/blueprint.xml
Outdated
Show resolved
Hide resolved
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
We may need changes on Minion side as well ( config.properties), Please evaluate on Minion
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Can you test this with suggested changes from https://opennms.atlassian.net/browse/NMS-16359?focusedCommentId=116235
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
We need to backport this to foundation-2023.
easy way to do this to use git onto
git checkout MJ/jira/NMS-16359-
git rebase --onto foundation-2023 origin/develop
git push --force
I test it on minion through runInPlace . Its working |
I just added the suggested change into smoke test . Its working |
Looks like we don't support Java 17 on |
e8bc6e1
to
5bdbfc8
Compare
Fixes Device config backup ssh client throws key spec not recognised: class net.i2p.crypto.eddsa.spec.EdDSAPublicKeySpec