Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

NMS-16359: Fix Device config backup with EddSA #7624

Open
wants to merge 9 commits into
base: develop
Choose a base branch
from

Conversation

Mohammad-Junid
Copy link
Contributor

@Mohammad-Junid Mohammad-Junid commented Feb 12, 2025

Fixes Device config backup ssh client throws key spec not recognised: class net.i2p.crypto.eddsa.spec.EdDSAPublicKeySpec

@Mohammad-Junid Mohammad-Junid marked this pull request as ready for review February 18, 2025 10:37
Copy link
Contributor

@cgorantla cgorantla left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We also need to evaulate this on Minion, might need changes on config.properties on Minion as well.

Copy link
Contributor

@cgorantla cgorantla left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We may need changes on Minion side as well ( config.properties), Please evaluate on Minion

@cgorantla cgorantla changed the title NMS-16359 Device config backup ssh NMS-16359: Fix Device config backup with EddSA Feb 19, 2025
Copy link
Contributor

@cgorantla cgorantla left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can you test this with suggested changes from https://opennms.atlassian.net/browse/NMS-16359?focusedCommentId=116235

Copy link
Contributor

@cgorantla cgorantla left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We need to backport this to foundation-2023.

easy way to do this to use git onto

git checkout MJ/jira/NMS-16359-
git rebase --onto foundation-2023 origin/develop
git push --force

@Mohammad-Junid
Copy link
Contributor Author

We may need changes on Minion side as well ( config.properties), Please evaluate on Minion

I test it on minion through runInPlace . Its working

@Mohammad-Junid
Copy link
Contributor Author

Can you test this with suggested changes from https://opennms.atlassian.net/browse/NMS-16359?focusedCommentId=116235

I just added the suggested change into smoke test . Its working

@cgorantla
Copy link
Contributor

We need to backport this to foundation-2023.

easy way to do this to use git onto

git checkout MJ/jira/NMS-16359-
git rebase --onto foundation-2023 origin/develop
git push --force

Looks like we don't support Java 17 on foundation-2023. Let's re-target this to foundation-2024

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants