Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Upgrade generic-template to polkadot-stable2412 #401

Open
wants to merge 11 commits into
base: main
Choose a base branch
from

Conversation

4meta5
Copy link
Contributor

@4meta5 4meta5 commented Jan 10, 2025

Addresses #374 for generic-template only

  • runtime compilation with all dependencies upgraded to polkadot-stable2412
  • tests, CI, etc
  • all deps point to tags (rather than unprotected branches)

Repo/Forks to Upgrade

  • ethereum
  • evm
  • dancekit
  • moonkit
  • moonbeam
  • open runtime module library
  • pallet abstractions

Notable Changes

@4meta5 4meta5 self-assigned this Jan 10, 2025
Copy link

netlify bot commented Jan 10, 2025

Deploy Preview for docs-oz-polkadot canceled.

Name Link
🔨 Latest commit 2966d02
🔍 Latest deploy log https://app.netlify.com/sites/docs-oz-polkadot/deploys/67902cd6c5a729000826f004

@4meta5

This comment was marked as resolved.

@4meta5

This comment was marked as resolved.

@4meta5 4meta5 added priority: 3 We will resolve this first before everything else. dependencies Pull requests that update a dependency file labels Jan 12, 2025
@4meta5

This comment was marked as resolved.

@4meta5

This comment was marked as resolved.

@4meta5 4meta5 marked this pull request as ready for review January 21, 2025 23:25
@4meta5
Copy link
Contributor Author

4meta5 commented Jan 21, 2025

CI error is surprising because the rust-toolchain.toml in generic-runtime-template is set to nightly-2024-06-22:

error[E0658]: use of unstable library feature 'is_none_or'
Error:    --> /home/runner/.cargo/registry/src/index.crates.io-6f17d22bba15001f/netlink-proto-0.11.4/src/connection.rs:243:18
    |
243 |                 .is_none_or(|x| x.is_closed())
    |                  ^^^^^^^^^^
    |
    = note: see issue #126383 <https://github.com/rust-lang/rust/issues/126383> for more information
    = help: add `#![feature(is_none_or)]` to the crate attributes to enable
    = note: this compiler was built on 2024-06-21; consider upgrading it if it is out of date

For more information about this error, try `rustc --explain E0658`.
error: could not compile `netlink-proto` (lib) due to 1 previous error
warning: build failed, waiting for other jobs to finish...
error: command `/home/runner/.rustup/toolchains/nightly-2024-06-22-x86_64-unknown-linux-gnu/bin/cargo test --no-run --message-format json-render-diagnostics --release` exited with code 101

Is there some other command that needs to be run in the CI environment when we have to upgrade the rust compiler version used @KitHat @ggonzalez94 ?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
dependencies Pull requests that update a dependency file priority: 3 We will resolve this first before everything else.
Projects
Status: 👀 In Review
Development

Successfully merging this pull request may close these issues.

1 participant