-
Notifications
You must be signed in to change notification settings - Fork 2.4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Added ContentPicker Validation For Required Fields #17470
base: main
Are you sure you want to change the base?
Conversation
Thank you for submitting your first pull request, awesome! 🚀 If you haven't already, please take a moment to review our contribution guide. This guide provides helpful information to ensure your contribution aligns with our standards. A core team member will review your pull request. |
@Sandeep905 please read the following Contributor License Agreement(CLA). If you agree with the CLA, please reply with the following information.
Contributor License AgreementContribution License AgreementThis Contribution License Agreement ( “Agreement” ) is agreed to by the party signing below ( “You” ), 1. Definitions. “Code” means the computer software code, whether in human-readable or machine-executable form, “Project” means any of the projects owned or managed by .NET Foundation and offered under a license “Submit” is the act of uploading, submitting, transmitting, or distributing code or other content to any “Submission” means the Code and any other copyrightable material Submitted by You, including any 2. Your Submission. You must agree to the terms of this Agreement before making a Submission to any 3. Originality of Work. You represent that each of Your Submissions is entirely Your 4. Your Employer. References to “employer” in this Agreement include Your employer or anyone else 5. Licenses. a. Copyright License. You grant .NET Foundation, and those who receive the Submission directly b. Patent License. You grant .NET Foundation, and those who receive the Submission directly or c. Other Rights Reserved. Each party reserves all rights not expressly granted in this Agreement. 6. Representations and Warranties. You represent that You are legally entitled to grant the above 7. Notice to .NET Foundation. You agree to notify .NET Foundation in writing of any facts or 8. Information about Submissions. You agree that contributions to Projects and information about 9. Governing Law/Jurisdiction. This Agreement is governed by the laws of the State of Washington, and 10. Entire Agreement/Assignment. This Agreement is the entire agreement between the parties, and .NET Foundation dedicates this Contribution License Agreement to the public domain according to the Creative Commons CC0 1. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Regarding the style don't change this file instead change the one in the Styles
folder
OrchardCore/src/OrchardCore.Modules/OrchardCore.Resources/ResourceManagementOptionsConfiguration.cs
Lines 493 to 498 in 3de1e7f
manifest | |
.DefineStyle("vue-multiselect") | |
.SetUrl("~/OrchardCore.Resources/Styles/vue-multiselect.min.css", "~/OrchardCore.Resources/Styles/vue-multiselect.min.css") | |
.SetCdn("https://cdn.jsdelivr.net/npm/[email protected]/dist/vue-multiselect.min.css", "https://cdn.jsdelivr.net/npm/[email protected]/dist/vue-multiselect.min.css") | |
.SetCdnIntegrity("sha384-PPH/T7V86Z1+B4eMPef4FJXLD5fsTpObWoCoK3CiNtSX7aji+5qxpOCn1f2TDYAM", "sha384-PPH/T7V86Z1+B4eMPef4FJXLD5fsTpObWoCoK3CiNtSX7aji+5qxpOCn1f2TDYAM") | |
.SetVersion("2.1.6"); |
src/OrchardCore.Modules/OrchardCore.ContentFields/Views/ContentPickerField.Edit.cshtml
Outdated
Show resolved
Hide resolved
src/OrchardCore.Modules/OrchardCore.ContentFields/Views/ContentPickerField.Edit.cshtml
Outdated
Show resolved
Hide resolved
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thank you!
Yep, what Hisham says. See https://docs.orchardcore.net/en/latest/guides/gulp-pipeline/. That's why https://github.com/OrchardCMS/OrchardCore/actions/runs/13251045412?pr=17470 fails.
When addressing review feedback, please adhere to the following:
- Please update your pull request according to feedback until it is approved by one of the core team members.
- Apply suggested changes directly so the reviewer doesn't have to eyeball the changes. These resolve themselves after applying them, and that's fine.
- Don't resolve other conversations so it's easier to track for the reviewer. Then, the reviewer will resolve them.
- Feel free to mark conversations that you addressed to keep track of them with an emoji or otherwise, just don't resolve them.
- Please keep conversations happening in line comments in those convos, otherwise, communication will be a mess. If you have trouble finding them, see this video.
- When you're done addressing all feedback of a review, click "Re-request review" in the top-right corner for each reviewer when you're ready for another round of review, so they know that you're done.
src/OrchardCore.Modules/OrchardCore.ContentFields/Views/ContentPickerField.Edit.cshtml
Outdated
Show resolved
Hide resolved
src/OrchardCore.Modules/OrchardCore.ContentFields/Views/ContentPickerField.Edit.cshtml
Outdated
Show resolved
Hide resolved
…tPickerField.Edit.cshtml Co-authored-by: Zoltán Lehóczky <[email protected]>
Unable to find the Style folder in OrchardCore.Resources -> Style Let me know what am I missing @hishamco ? |
It seems it's a bug that I need to fix after I check the input for the assets coming from Your thoughts @Piedone? |
No bug here, the asset file will output the styles & scripts in the |
You'll either need to add a new SCSS file to |
@Sandeep905 could you please share the style that has been added for this PR, looking into a minified version is hard, then we can check how we can go |
.Content-Picker-Required .multiselect__tags{ @hishamco here it is. |
So let us create a style file for it like what @Piedone suggested |
I didn't understand what you mean |
Are you creating the style file as suggested for the custom CSS I shared? |
I mean create a SCSS file with your changes |
Fixes #17462
I tried to fix the above-linked Issue. @Piedone I am not sure if this approach is acceptable or not. If not let me know how I can fix the issue. This will be the first-ever open-source contribution from my end.
![image](https://private-user-images.githubusercontent.com/61585735/411648983-1521751f-d529-4b62-a32f-0358c5cec0c9.png?jwt=eyJhbGciOiJIUzI1NiIsInR5cCI6IkpXVCJ9.eyJpc3MiOiJnaXRodWIuY29tIiwiYXVkIjoicmF3LmdpdGh1YnVzZXJjb250ZW50LmNvbSIsImtleSI6ImtleTUiLCJleHAiOjE3Mzk0MzE1OTgsIm5iZiI6MTczOTQzMTI5OCwicGF0aCI6Ii82MTU4NTczNS80MTE2NDg5ODMtMTUyMTc1MWYtZDUyOS00YjYyLWEzMmYtMDM1OGM1Y2VjMGM5LnBuZz9YLUFtei1BbGdvcml0aG09QVdTNC1ITUFDLVNIQTI1NiZYLUFtei1DcmVkZW50aWFsPUFLSUFWQ09EWUxTQTUzUFFLNFpBJTJGMjAyNTAyMTMlMkZ1cy1lYXN0LTElMkZzMyUyRmF3czRfcmVxdWVzdCZYLUFtei1EYXRlPTIwMjUwMjEzVDA3MjEzOFomWC1BbXotRXhwaXJlcz0zMDAmWC1BbXotU2lnbmF0dXJlPWQ0OWQ0NzIyOGVjMDM4NjE1MDE0NDkyNTViOWI5Zjg5MWQ2MmE1YzdhNzRkYmRmMzcwNzUyZGI4ZjkzMmNhYTcmWC1BbXotU2lnbmVkSGVhZGVycz1ob3N0In0.-DT9-bCJg463trh8U6e6fbP_nR0IoarVJeEIpPaY-1U)