Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

STAR-1275: Read the peers SRT version and the negotiated latency from the socket #26

Conversation

permobergedge
Copy link

Suggestion of a way to pass SRT library version from client and the negotiated latency back to the user of SRTNet.

We can then extend our logs from for example:
[2024-05-07 16:19:00.737] [LD_Pipeline] [acl-renderingen-771773] [info] program 1: Client connected to server: 127.0.0.1:4567
to:
[2024-05-07 16:19:00.737] [LD_Pipeline] [acl-renderingen-771773] [info] program 1: Client connected to server: 127.0.0.1:4567, SRT version: 1.4.4, latency: 3098

Copy link

@tomasoh-ateliere tomasoh-ateliere left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great addition!

SRTNet.cpp Outdated Show resolved Hide resolved
SRTNet.cpp Outdated Show resolved Hide resolved
SRTNet.cpp Outdated Show resolved Hide resolved
SRTNet.h Show resolved Hide resolved
SRTNet.h Outdated Show resolved Hide resolved
@permobergedge permobergedge force-pushed the star-1275-pass-client-srt-version-and-latency-to-connected-callbacks branch 2 times, most recently from d4e3b5c to 0f47a9f Compare May 10, 2024 08:52
Copy link

@tomasoh-ateliere tomasoh-ateliere left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good now!

SRTNet.cpp Outdated Show resolved Hide resolved
… the socket

Pass a reference to a ConnectionInformation struct back to user
when a new client connects and the called connects to a server.
@permobergedge permobergedge force-pushed the star-1275-pass-client-srt-version-and-latency-to-connected-callbacks branch from ecef45b to 37ef9ba Compare May 10, 2024 09:10
@permobergedge permobergedge merged commit 098e373 into master May 10, 2024
3 checks passed
@permobergedge permobergedge deleted the star-1275-pass-client-srt-version-and-latency-to-connected-callbacks branch May 10, 2024 12:47
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants