Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

STAR-1302: enable sending Stream ID #27

Merged
merged 1 commit into from
May 30, 2024
Merged

Conversation

magnusedgeware
Copy link

No description provided.

Copy link

@permobergedge permobergedge left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice implementation!

The list of arguments for the start functions is starting to become really long now.. might consider in the future to maybe collect them in some struct(s)

Copy link

@nilsandgren nilsandgren left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Loooking good! 🍓 🍍 🍒

Copy link

@permobergedge permobergedge left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks even better now with the improved test case :) 👍

@magnusedgeware magnusedgeware merged commit 22ebdd7 into master May 30, 2024
3 checks passed
@permobergedge permobergedge deleted the star-1302-streamid branch May 30, 2024 12:51
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants