-
-
Notifications
You must be signed in to change notification settings - Fork 658
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Adding more options for configuring ping passthrough. #1290
base: dev/3.0.0
Are you sure you want to change the base?
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This should either respect the original option or handle migration
proxy/src/main/java/com/velocitypowered/proxy/connection/util/ServerListPingHandler.java
Outdated
Show resolved
Hide resolved
proxy/src/main/java/com/velocitypowered/proxy/connection/util/ServerListPingHandler.java
Outdated
Show resolved
Hide resolved
proxy/src/main/java/com/velocitypowered/proxy/connection/util/ServerListPingHandler.java
Outdated
Show resolved
Hide resolved
proxy/src/main/java/com/velocitypowered/proxy/connection/util/ServerListPingHandler.java
Outdated
Show resolved
Hide resolved
proxy/src/main/java/com/velocitypowered/proxy/connection/util/ServerListPingHandler.java
Outdated
Show resolved
Hide resolved
proxy/src/main/java/com/velocitypowered/proxy/connection/util/ServerListPingHandler.java
Outdated
Show resolved
Hide resolved
Those changes are fine. |
…ServerListPingHandler.java Co-authored-by: powercas_gamer <[email protected]>
…ServerListPingHandler.java Co-authored-by: powercas_gamer <[email protected]>
…ServerListPingHandler.java Co-authored-by: powercas_gamer <[email protected]>
…ServerListPingHandler.java Co-authored-by: powercas_gamer <[email protected]>
…ServerListPingHandler.java Co-authored-by: powercas_gamer <[email protected]>
…ServerListPingHandler.java Co-authored-by: powercas_gamer <[email protected]>
It took me months to understand what you were trying to say here; what you wanted me to do, and still longer for me to actually do it. For some reason, I only focused on the minor changes you had requested, and not your actual comment. But today, I sat down and implemented what you actually wanted. My branch now supports falling back to the old ping passthrough system if the new one isn't in use. I've tested the code on my server and the fallback works. |
It has been over a month. Please either merge/close my pull request, or tell me why you don't want to merge it. At some point I will have to update my proxy, but I can no longer sync my fork, meaning I can't update my proxy unless you merge my fork. If you don't give me some kind of response in the next month or two, I'll probably open a new pull request because I don't know what else to do. |
I dont want to touch anything config related until I've replaced the
configuration system, which is somewhat of a low priority at the moment
between IRL transitions post having my cornea carved out. I'd suggest
moving this over to a branch and creating a new PR
…On Tue, 11 Feb 2025 at 23:13, Loganius ***@***.***> wrote:
It has been over a month. Please either merge/close my pull request, or
tell me why you don't want to merge it. At some point I will *have* to
update my proxy, but I can no longer sync my fork until you merge it. If
you don't give me *some* kind of response in the next month or two, I'll
probably open a new pull request because I don't know what else to do.
—
Reply to this email directly, view it on GitHub
<#1290 (comment)>,
or unsubscribe
<https://github.com/notifications/unsubscribe-auth/AAJMAZAKXGMB5DXKQKF7NSD2PJ7YPAVCNFSM6AAAAABUN7F4GSVHI2DSMVQWIX3LMV43OSLTON2WKQ3PNVWWK3TUHMZDMNJSGI3TCMZQGA>
.
You are receiving this because you are subscribed to this thread.Message
ID: ***@***.***>
|
Thank you for the quick reply. I will certainly do that! Though probably not right now, because I too am not doing so great IRL (though in my case it's just a cold :P). I will close this pull request once I've done that. |
When using Velocity, I have been frustrated by the lack of fine control over ping passthrough, specifically the lack of support for passing through favicons without passing through the whole ping request. I've also seen people on line asking how to pass through favicons, so I decided to add the ability to control which aspects of server list ping requests are passed through from the back end server, and which aspects aren't, through 5 new boolean configuration options in the config file.
Please don't judge my code too harshly, this is my first time writing Java, but it does compile and Checkstyle is okay with it.