Dividing TabCompleteEvent into TabCompleteRequestEvent and TabCompleteResultEvent #1509
+110
−34
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…tEvent and TabCompleteResultEvent
novitpw
approved these changes
Feb 12, 2025
| @@ -783,6 +790,20 @@ private void finishRegularTabComplete(TabCompleteRequestPacket request, | |||
| request, response, ex); | |||
| return null; | |||
| }); | |||
| server.getEventManager().fire(new TabCompleteResultEvent(player, request.getCommand(), offers)) | |||
There was a problem hiding this comment.
Used to distinguish from the previous TabCompleteEvent and improve the recognition of the function (that is, triggered when the server produces a result in response to a tab request), although the logic is almost the same as TabCompleteEvent
There was a problem hiding this comment.
At least I don't see any use for this event, since TabCompleteEvent allows you to do everything you need. Maybe you just didn't delete the code above? If so, I advise you to reconsider the event names.
There was a problem hiding this comment.
You do have a point. So I've restored TabCompleteEvent and removed TabCompleteResultEvent in the latest commit, since the two classes do essentially the same thing.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
As you can see, TabCompleteEvent is now deprecated and is divided into TabCompleteRequestEvent and TabCompleteResultEvent.