Init config refactor #2035
Draft
Init config refactor #2035
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
added 3 commits
February 21, 2025 19:44
-- Moved InitConfig into InitServer and InitClient -- Replaced calls of InitConfig with InitServer and InitClient where possible -- Removed calls to InitConfigDir where possible -- Adjusted the tests where needed due to the changes made
This was
linked to
issues
Feb 21, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Moved InitConfig into InitServer and InitClient and adjusts the tests as needed.
Also made InitConfigDir platform agnostic.
Ideally, I would like to be able to make InitConfig private, but its use in the cmd/config_printer test makes that impossible.
I'm worried InitConfig will keep being used in tests until we figure out a solution for that if the author/reviewer don't catch it organically.