Fixed setting scan output config #29
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Merged
bkurtz
reviewed
Aug 17, 2020
There was a problem hiding this comment.
Seems like generally a step in the right direction, but I don't see anything that will actually restart the data streaming connection to update the start_angle or max_num_points_scan parameters used by the hardware during capture. That seems like it could get kinda complicated, so maybe it's not desirable to support it yet, but it seems like in that case we probably shouldn't support dynamic reconfigure of those parameters at all?
| if(product_ != "R2000") | ||
| return; | ||
| if(state_ != PFState::RUNNING) | ||
| return; | ||
| protocol_interface_->handle_reconfig(config, level); |
| { | ||
| protocol_interface_->handle_reconfig(config, level); | ||
| } | ||
| pipeline_->set_scanoutput_config(config_); |
There was a problem hiding this comment.
Just to be clear, this will set the output published to ROS, but I don't see anywhere this causes a change in the data collected from the R2000/R2300, right?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Addressing #25
Some params should be set with
set_scanoutput_configand not withset_parameter