Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add Regex option for HeaderConfig #46

Open
wants to merge 5 commits into
base: master
Choose a base branch
from
Open

Add Regex option for HeaderConfig #46

wants to merge 5 commits into from

Conversation

alex-tan
Copy link

Addresses #42.

This seems to resolve the issue for me, but I welcome any feedback.

PierreZ
PierreZ reviewed Jul 11, 2021
View reviewed changes
Copy link
Owner

@PierreZ PierreZ left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the PR! I left some comments

@alex-tan
Don't panic when regex doesn't compile
d0e5eca 
Instead, print a warning and discard the invalid rule.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@PierreZ PierreZ PierreZ left review comments

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@alex-tan @PierreZ