Add configs for self-hosting in a Kubernetes cluster #5
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
added 7 commits
November 18, 2024 23:54
ddanielgal
commented
Nov 19, 2024
| FROM node:18.16 as builder | ||
| FROM node:18.16 |
There was a problem hiding this comment.
Reason for switching to single-stage build for this image: the COPY command copying over node_modules failed on the _mocha package because of linked files.
There was a problem hiding this comment.
Just my 2c, I dont think that moving away from multistage builds is a good idea. If there is a problem we should address, I'd rather do it differently.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I am hosting Omnivore on my public VPS using this config.
See
GUIDE.mdin this PR.Newsletters feature not included.