Improve AI output #2136
Open
Improve AI output #2136
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mikesmit
reviewed
Feb 4, 2025
| input_data = { | ||
| "country_id": country_id, | ||
| } | ||
| for key in payload: |
There was a problem hiding this comment.
question what is this doing and why are we doing it?
There was a problem hiding this comment.
This route is meant to take a series of prompt inputs (as keys in a dict) and the name of a prompt and return the AI prompt pre-filled, but without actually enqueuing AI processing from Claude.
These prompts take keys of differing names, values, and types, and so this code pops payload items and adds them into a dictionary to be passed to the service, which then validates if that input data object contains all of the required keys. It also now uses Pydantic to validate the types of these args.
Question for you: do you feel there's a better approach to this process?
anth-volk
force-pushed
the
fix/improve-ai-output
branch
from
7872f19 to
5c15c72
Compare
…prompt generation
…n analysis already exists
anth-volk
force-pushed
the
fix/improve-ai-output
branch
from
5c15c72 to
c3cef39
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #2131
Fixes #2126
Fixes #2125
Required for PolicyEngine/policyengine-app#2325
Required for PolicyEngine/policyengine-app#2321
In an effort to make our AI output endpoints more sustainable, resilient, and modular, this PR does the following:
string.replaceto provide clearer behaviorAIPromptBaseclass to be used for more systematized prompt generation and improved user interfaceThe changes here are required to enable a front-end PR implementing fixes for PolicyEngine/policyengine-app#2325 and PolicyEngine/policyengine-app#2321.
This code does not yet add tests, hence opening in draft form. I'd like these tests to mirror the structure proposed in #2114, and thus will implement that folder and test structure for these tests, and then refactor based upon future movement on that PR.