Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

API Architecture doc blog post #2345

Merged
merged 1 commit into from
Feb 12, 2025
Merged

API Architecture doc blog post #2345

merged 1 commit into from
Feb 12, 2025
+243 −0

Conversation

mikesmit
Copy link
Collaborator

@mikesmit mikesmit commented Feb 6, 2025

fixes #2344

  1. Created an article on the new design
  2. added myself and a photo of me as an author
  3. added the article to the manifest

@mikesmit mikesmit requested a review from MaxGhenis February 6, 2025 16:33
@vercel Vercel
Copy link

vercel bot commented Feb 6, 2025 •
edited
Loading

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
policyengine-app ✅ Ready (Inspect) Visit Preview 💬 Add feedback Feb 11, 2025 9:27pm

@mikesmit mikesmit requested a review from anth-volk February 6, 2025 17:25
anth-volk
anth-volk requested changes Feb 6, 2025
View reviewed changes
Copy link
Collaborator

@anth-volk anth-volk left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hi @mikesmit, thanks for your work on this. I limited the scope of my review to the technical implementation, as Max would be responsible for language, but did note a required change before we can merge.

src/posts/posts.json Outdated Show resolved Hide resolved
@mikesmit mikesmit force-pushed the 2344_publish_api_architecture branch from 1fec76e to e99d4aa Compare February 6, 2025 18:35
anth-volk
anth-volk approved these changes Feb 6, 2025
View reviewed changes
Copy link
Collaborator

@anth-volk anth-volk left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This looks great @mikesmit! If you could just run the linter and merge, pending approval of the content, this will be good to merge.

@mikesmit mikesmit force-pushed the 2344_publish_api_architecture branch from e99d4aa to 3065229 Compare February 6, 2025 18:58
@mikesmit mikesmit force-pushed the 2344_publish_api_architecture branch from 3065229 to 95a231e Compare February 10, 2025 19:39
MaxGhenis
MaxGhenis requested changes Feb 10, 2025
View reviewed changes
Copy link
Contributor

@MaxGhenis MaxGhenis left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Could you run make format to pass lint? Please also confirm you tested it locally.

src/posts/posts.json Outdated Show resolved Hide resolved
@mikesmit
Copy link
Collaborator Author

I tested by running it locally and looking at the article in my local browser (I.e. make debug).
Screenshot 2025-02-11 13 23 55
Screenshot 2025-02-11 13 23 34
Screenshot 2025-02-11 13 23 23

@mikesmit mikesmit force-pushed the 2344_publish_api_architecture branch from 95a231e to 5a79302 Compare February 11, 2025 21:25
@MaxGhenis MaxGhenis merged commit 72e1ebb into master Feb 12, 2025
4 checks passed
@MaxGhenis MaxGhenis deleted the 2344_publish_api_architecture branch February 12, 2025 15:14
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@MaxGhenis MaxGhenis MaxGhenis approved these changes

@anth-volk anth-volk anth-volk approved these changes

Assignees
No one assigned
Labels
None yet
Projects
policyengine-app
Status: Done
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Publish target API architecture on blog
3 participants
@mikesmit @MaxGhenis @anth-volk